ZihanLi58 commented on code in PR #3544:
URL: https://github.com/apache/gobblin/pull/3544#discussion_r959864617
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -183,6 +186,7 @@ public void onDeleteSpec(URI deletedSpecURI, String
deletedSpecVersion, Properti
_log.info("Spec deletion detected: " + deletedSpecURI + "/" +
deletedSpecVersion);
if (topologyCatalog.isPresent()) {
+ //todo: de-risk: flow spec and topology spec share same uri?
Review Comment:
yeah, that's what I'm worry about, if that happens, we will ends up with
issue that affect all the flows. Might be better to add the info of spec type
in to properties?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
