ZihanLi58 commented on code in PR #3544:
URL: https://github.com/apache/gobblin/pull/3544#discussion_r959868355
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_catalog/FlowCatalog.java:
##########
@@ -383,10 +387,17 @@ public Map<String, AddSpecResponse> put(Spec spec,
boolean triggerListener) thro
return responseMap;
}
}
- AddSpecResponse<String> schedulerResponse =
responseMap.getOrDefault(ServiceConfigKeys.GOBBLIN_SERVICE_JOB_SCHEDULER_LISTENER_CLASS,
new AddSpecResponse<>(null));
+ AddSpecResponse<String> compileResponse;
+ if (isWarmStandbyEnabled) {
+ compileResponse =
responseMap.getOrDefault(ServiceConfigKeys.GOBBLIN_ORCHESTRATOR_LISTENER_CLASS,
new AddSpecResponse<>(null));
+ //todo: do we check quota here? or in compiler? Quota manager need dag
to check quota which is not accessable from this class
Review Comment:
When I say check quota, it's only for adhoc and run immediate flow. Since
after this step, we put the change in mysql table and return accept to user
which means we will run the flow anyway on leader host. So before we put it
into mysql table, for achoc and run immediate flow, we need to check the quota
first, either here or in compiler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
