[
https://issues.apache.org/jira/browse/GOBBLIN-1689?focusedWorklogId=805036&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805036
]
ASF GitHub Bot logged work on GOBBLIN-1689:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/22 23:04
Start Date: 30/Aug/22 23:04
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3544:
URL: https://github.com/apache/gobblin/pull/3544#discussion_r959003407
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -191,6 +195,9 @@ public void onDeleteSpec(URI deletedSpecURI, String
deletedSpecVersion, Properti
@Override
public void onUpdateSpec(Spec updatedSpec) {
_log.info("Spec changed: " + updatedSpec);
+ if (updatedSpec instanceof FlowSpec) {
Review Comment:
Don't we want to call `onDeleteSpec` and `onAddSpec` for FlowSpec, like we
are doing for TopologySpec?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -191,6 +195,9 @@ public void onDeleteSpec(URI deletedSpecURI, String
deletedSpecVersion, Properti
@Override
public void onUpdateSpec(Spec updatedSpec) {
_log.info("Spec changed: " + updatedSpec);
+ if (updatedSpec instanceof FlowSpec) {
Review Comment:
Don't we want to call `onDeleteSpec` and `onAddSpec` sequentially for
FlowSpec, like we are doing for TopologySpec?
Issue Time Tracking
-------------------
Worklog Id: (was: 805036)
Time Spent: 1.5h (was: 1h 20m)
> Decouple compiler from scheduler in warm standby mode
> ------------------------------------------------------
>
> Key: GOBBLIN-1689
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1689
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Now, when add/update flow spec, we rely on scheduler to compile the flow and
> return status, but in warm standby mode, where every host can accept and
> process request but not running the flow, we should be able to compile flow
> without scheduler.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
