[
https://issues.apache.org/jira/browse/GOBBLIN-1689?focusedWorklogId=805330&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805330
]
ASF GitHub Bot logged work on GOBBLIN-1689:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Aug/22 17:53
Start Date: 31/Aug/22 17:53
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3544:
URL: https://github.com/apache/gobblin/pull/3544#discussion_r959866424
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -191,6 +195,9 @@ public void onDeleteSpec(URI deletedSpecURI, String
deletedSpecVersion, Properti
@Override
public void onUpdateSpec(Spec updatedSpec) {
_log.info("Spec changed: " + updatedSpec);
+ if (updatedSpec instanceof FlowSpec) {
Review Comment:
I think we don't need delete spec for flow spec? As nothing needed on
compiler side when we delete one flow? We just want to make sure the new spec
is compilable.
Issue Time Tracking
-------------------
Worklog Id: (was: 805330)
Time Spent: 2h 50m (was: 2h 40m)
> Decouple compiler from scheduler in warm standby mode
> ------------------------------------------------------
>
> Key: GOBBLIN-1689
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1689
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Now, when add/update flow spec, we rely on scheduler to compile the flow and
> return status, but in warm standby mode, where every host can accept and
> process request but not running the flow, we should be able to compile flow
> without scheduler.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
