[
https://issues.apache.org/jira/browse/GOBBLIN-1689?focusedWorklogId=805333&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805333
]
ASF GitHub Bot logged work on GOBBLIN-1689:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Aug/22 17:58
Start Date: 31/Aug/22 17:58
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3544:
URL: https://github.com/apache/gobblin/pull/3544#discussion_r959861548
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java:
##########
@@ -393,7 +393,10 @@ private void configureServices(){
registerServicesInLauncher();
// Register Scheduler to listen to changes in Flows
- if (configuration.isSchedulerEnabled()) {
+ // In warm standby mode, instead of scheduler we will add orchestrator as
listener
Review Comment:
I see we seems to have different compiler class based on the config, but on
flow catalog side we need the class name to get the compile result, that's why
I use orchestrator as it's constant...
Another thing is that we need to set the compiler as active and listen to
topology catalog's change, so want to make sure we only have one compiler in
the service
Issue Time Tracking
-------------------
Worklog Id: (was: 805333)
Time Spent: 3h 10m (was: 3h)
> Decouple compiler from scheduler in warm standby mode
> ------------------------------------------------------
>
> Key: GOBBLIN-1689
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1689
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Now, when add/update flow spec, we rely on scheduler to compile the flow and
> return status, but in warm standby mode, where every host can accept and
> process request but not running the flow, we should be able to compile flow
> without scheduler.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
