[
https://issues.apache.org/jira/browse/GOBBLIN-1904?focusedWorklogId=880097&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-880097
]
ASF GitHub Bot logged work on GOBBLIN-1904:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/23 04:41
Start Date: 13/Sep/23 04:41
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3768:
URL: https://github.com/apache/gobblin/pull/3768#discussion_r1323911381
##########
gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/Histogram.java:
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.salesforce;
+
+import java.util.ArrayList;
+import java.util.List;
+import lombok.Getter;
+
+
+@Getter
+public class Histogram {
+ private long totalRecordCount;
+ private final List<HistogramGroup> groups;
+
+ Histogram() {
Review Comment:
package-protected is quite uncommon in the repo, and certainly not "the
default". if you're specifically choosing that, please explain the reasoning
in the class-level javadoc. otherwise, make this `public`, `protected`,
whatever
Issue Time Tracking
-------------------
Worklog Id: (was: 880097)
Time Spent: 50m (was: 40m)
> Refactor Salesforce Source to promote testability
> -------------------------------------------------
>
> Key: GOBBLIN-1904
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1904
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Salesforce source is difficult to test due to many internal classes that
> cannot mock inputs and outputs. We should clean this class and use
> composition to promote testability.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
