[
https://issues.apache.org/jira/browse/GOBBLIN-1904?focusedWorklogId=880098&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-880098
]
ASF GitHub Bot logged work on GOBBLIN-1904:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/23 04:42
Start Date: 13/Sep/23 04:42
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3768:
URL: https://github.com/apache/gobblin/pull/3768#discussion_r1323924378
##########
gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceSource.java:
##########
@@ -155,19 +133,25 @@ protected void addLineageSourceInfo(SourceState
sourceState, SourceEntity entity
}
@Override
protected List<WorkUnit> generateWorkUnits(SourceEntity sourceEntity,
SourceState state, long previousWatermark) {
- List<WorkUnit> workUnits = null;
- workUnitConf = new SfConfig(state.getProperties());
+ SalesforceConnector connector = getConnector(state);
Review Comment:
if used only to initialize the histogram service, scope it to within that
(`== null`) path of the conditional
Issue Time Tracking
-------------------
Worklog Id: (was: 880098)
Time Spent: 1h (was: 50m)
> Refactor Salesforce Source to promote testability
> -------------------------------------------------
>
> Key: GOBBLIN-1904
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1904
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Salesforce source is difficult to test due to many internal classes that
> cannot mock inputs and outputs. We should clean this class and use
> composition to promote testability.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
