phet commented on code in PR #3776: URL: https://github.com/apache/gobblin/pull/3776#discussion_r1326696652
########## gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/FinishResumeDagProc.java: ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.gobblin.service.modules.orchestration; + +import java.io.IOException; +import java.util.Map; +import java.util.concurrent.ExecutionException; + +import lombok.extern.slf4j.Slf4j; + +import org.apache.gobblin.runtime.api.DagActionStore; +import org.apache.gobblin.service.modules.flowgraph.Dag; +import org.apache.gobblin.service.modules.orchestration.exception.MaybeRetryableException; +import org.apache.gobblin.service.modules.spec.JobExecutionPlan; +import org.apache.gobblin.service.monitoring.JobStatus; + +import static org.apache.gobblin.service.ExecutionStatus.CANCELLED; +import static org.apache.gobblin.service.ExecutionStatus.FAILED; +import static org.apache.gobblin.service.ExecutionStatus.PENDING_RESUME; + + +/** + * An implementation of {@link DagProc} that will process {@link DagTask} will PENDING_RESUME job status. + * This can be handled either via {@link AdvanceDagProc} or have a separate procedure to handle PENDING_RESUME events. + * Currently, I have this boilerplate code, but can decide if it makes have a separate procedure for completion of + * PENDING_RESUME events. + */ +@WorkInProgress +@Slf4j +public class FinishResumeDagProc extends DagProc { + private DagManagementStateStore dagManagementStateStore = new DagManagementStateStore(); + + private DagTaskStream dagTaskStream; + private DagStateStore dagStateStore; + private DagStateStore failedDagStateStore; + + @Override + protected Object initialize() { Review Comment: looks like `act` starts off by reading state. why not perform that here, in `initialize()`? the idea with separating them is to recognize which kind of failure should be retried? e.g. did we fail to initialize or fail in taking our action? if only the latter, then we may continue to use the state already successfully initialized and merely try again to `act` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
