phet commented on code in PR #3776: URL: https://github.com/apache/gobblin/pull/3776#discussion_r1329306248
########## gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagProc.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.service.modules.orchestration; + +import java.io.IOException; +import java.util.concurrent.ExecutionException; + +import lombok.extern.slf4j.Slf4j; + +import org.apache.gobblin.annotation.Alpha; +import org.apache.gobblin.service.modules.orchestration.exception.MaybeRetryableException; + + +/** + * Responsible to performing the actual work for a given {@link DagTask}. + * It processes the {@link DagTask} by first initializing its state, performing actions + * based on the type of {@link DagTask} and finally submitting an event to the executor. + * @param <S> current state of the dag node + * @param <R> result after processing the dag node + */ +@Alpha +@Slf4j +public abstract class DagProc<S, R> { + abstract protected S initialize() + throws MaybeRetryableException, IOException; + abstract protected R act(S state) throws ExecutionException, InterruptedException, IOException; + abstract protected void sendNotification(R result) throws MaybeRetryableException; + + public void process() { Review Comment: I like this impl... we just need to sketch out how it communicates whether or not it succeeded (and hence whether the lease should be completed or not). specify that in method-level javadoc. e.g. perhaps we say success is when we don't throw an exception. otherwise, might neet to return a flag/sentinel value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
