[
https://issues.apache.org/jira/browse/GOBBLIN-1917?focusedWorklogId=881222&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-881222
]
ASF GitHub Bot logged work on GOBBLIN-1917:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Sep/23 17:37
Start Date: 21/Sep/23 17:37
Worklog Time Spent: 10m
Work Description: gautamguptabasant commented on code in PR #3786:
URL: https://github.com/apache/gobblin/pull/3786#discussion_r1333402625
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobTask.java:
##########
@@ -211,14 +211,15 @@ public TaskResult run() {
try {
this.jobsMapping.deleteMapping(jobUri);
} catch (Exception e) {
+ log.warn("Failed to delete jobs mapping for job: {}", jobUri, e);
return new TaskResult(TaskResult.Status.FAILED,"Cannot delete jobs
mapping for job : " + jobUri);
}
}
}
@Override
public void cancel() {
- log.info("Cancelling planning job {}", this.planningJobId);
+ log.info("Cancelling planning job {} | jobTaskMetrics: {}",
this.planningJobId, this.jobTaskMetrics);
Review Comment:
Thanks for catching this, fixed.
Issue Time Tracking
-------------------
Worklog Id: (was: 881222)
Time Spent: 0.5h (was: 20m)
> Logging updates for Salesforce classes
> --------------------------------------
>
> Key: GOBBLIN-1917
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1917
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-salesforce
> Reporter: Gautam Kumar
> Assignee: Hung Tran
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> - Updating the log messages in the Salesforce related classes.
> - In some cases, the exception was not included in the log. Adding it to make
> debugging issues easier.
> - For some cases, added more details in the logs to print the current
> progress of the tasks.
> - Minor coding style updates as well to improve code readability.
> - There are no functional changes in this PR
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
