[
https://issues.apache.org/jira/browse/GOBBLIN-1917?focusedWorklogId=881263&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-881263
]
ASF GitHub Bot logged work on GOBBLIN-1917:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Sep/23 00:41
Start Date: 22/Sep/23 00:41
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3786:
URL: https://github.com/apache/gobblin/pull/3786#discussion_r1333741471
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobTask.java:
##########
@@ -219,7 +219,7 @@ public TaskResult run() {
@Override
public void cancel() {
- log.info("Cancelling planning job {} | jobTaskMetrics: {}",
this.planningJobId, this.jobTaskMetrics);
+ log.info("Cancelling planning job {} | jobTaskMetrics: {}",
this.planningJobId, this.jobTaskMetrics.getMetrics());
Review Comment:
I think this still has an issue:
Going into the implementation of `StandardMetrics.getMetrics()` it returns a
`Map<String, Metric>`. When this is printed it would still return the reference
to the map instead of the contents. If you really want to print the metrics
here, we will need a custom log function where you traverse the Map<String,
Metric> and then print out the contexts as appropriate. But given that `Metric`
is just an interface in `metrics-core-4.1.2`, I think this would be tricky as
we would have to also implement a switch statement checking each type...
Which metric are you interested in here? Would it be possible just to limit
the scope to print only those metrics?
Issue Time Tracking
-------------------
Worklog Id: (was: 881263)
Time Spent: 50m (was: 40m)
> Logging updates for Salesforce classes
> --------------------------------------
>
> Key: GOBBLIN-1917
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1917
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-salesforce
> Reporter: Gautam Kumar
> Assignee: Hung Tran
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> - Updating the log messages in the Salesforce related classes.
> - In some cases, the exception was not included in the log. Adding it to make
> debugging issues easier.
> - For some cases, added more details in the logs to print the current
> progress of the tasks.
> - Minor coding style updates as well to improve code readability.
> - There are no functional changes in this PR
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
