[
https://issues.apache.org/jira/browse/GOBBLIN-1917?focusedWorklogId=881269&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-881269
]
ASF GitHub Bot logged work on GOBBLIN-1917:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Sep/23 02:21
Start Date: 22/Sep/23 02:21
Worklog Time Spent: 10m
Work Description: gautamguptabasant commented on code in PR #3786:
URL: https://github.com/apache/gobblin/pull/3786#discussion_r1333811858
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobTask.java:
##########
@@ -219,7 +219,7 @@ public TaskResult run() {
@Override
public void cancel() {
- log.info("Cancelling planning job {} | jobTaskMetrics: {}",
this.planningJobId, this.jobTaskMetrics);
+ log.info("Cancelling planning job {} | jobTaskMetrics: {}",
this.planningJobId, this.jobTaskMetrics.getMetrics());
Review Comment:
Hmm, somehow I read this map as <String, String>. Yes, this does look a bit
tricky to log. Omitting this change for now to get the rest of it in. Will
revisit this one later.
Issue Time Tracking
-------------------
Worklog Id: (was: 881269)
Time Spent: 1h (was: 50m)
> Logging updates for Salesforce classes
> --------------------------------------
>
> Key: GOBBLIN-1917
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1917
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-salesforce
> Reporter: Gautam Kumar
> Assignee: Hung Tran
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> - Updating the log messages in the Salesforce related classes.
> - In some cases, the exception was not included in the log. Adding it to make
> debugging issues easier.
> - For some cases, added more details in the logs to print the current
> progress of the tasks.
> - Minor coding style updates as well to improve code readability.
> - There are no functional changes in this PR
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
