umustafi commented on code in PR #3823:
URL: https://github.com/apache/gobblin/pull/3823#discussion_r1393412720
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -64,10 +64,12 @@ public final class FlowCompilationValidationHelper {
* For a given a flowSpec, verifies that an execution is allowed (in case
there is an ongoing execution) and the
* flowspec can be compiled. If the pre-conditions hold, then a
JobExecutionPlan is constructed and returned to the
* caller.
+ * @param flowSpec
+ * @param optionalFlowExecutionId provided for executions of scheduled
events which should use a consistent id
* @return jobExecutionPlan dag if one can be constructed for the given
flowSpec
*/
- public Optional<Dag<JobExecutionPlan>> createExecutionPlanIfValid(FlowSpec
flowSpec)
- throws IOException, InterruptedException {
+ public Optional<Dag<JobExecutionPlan>> createExecutionPlanIfValid(FlowSpec
flowSpec,
+ Optional<String> optionalFlowExecutionId) throws IOException,
InterruptedException {
Review Comment:
The other optionals used in this class are the guava one and reliant on
intertwined `Orchestrator/DagManager` code. I want to avoid the inconsistency
in this class for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
