Will-Lo commented on code in PR #3823:
URL: https://github.com/apache/gobblin/pull/3823#discussion_r1392886657
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -484,7 +484,8 @@ public synchronized void setActive(boolean active) {
log.error("Exception encountered when shutting down DagManager
threads.", e);
}
}
- } catch (IOException e) {
+ } catch (RuntimeException | IOException e) {
Review Comment:
Catching the runtime exception here wouldn't do anything because we're
rethrowing the runtime exception as a runtime exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
