umustafi commented on code in PR #3823:
URL: https://github.com/apache/gobblin/pull/3823#discussion_r1393393693
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -504,9 +504,12 @@ public void handleLaunchFlowEvent(DagActionStore.DagAction
launchAction) {
URI flowUri = FlowSpec.Utils.createFlowSpecUri(flowId);
FlowSpec spec = (FlowSpec) flowCatalog.getSpecs(flowUri);
Optional<Dag<JobExecutionPlan>> optionalJobExecutionPlanDag =
-
this.flowCompilationValidationHelper.createExecutionPlanIfValid(spec);
+
this.flowCompilationValidationHelper.createExecutionPlanIfValid(spec,
Optional.absent());
if (optionalJobExecutionPlanDag.isPresent()) {
addDag(optionalJobExecutionPlanDag.get(), true, true);
+ } else {
+ log.warn("Failed flow compilation of spec causing launch flow event to
be skipped on startup. Flow {}", flowId);
+ this.dagManagerMetrics.incrementFailedLaunchCount();
Review Comment:
Yep, we don't have that information available here yet. We emit a flow
compilation failed event that we can check
https://github.com/apache/gobblin/blob/9e30c6c3bca857942fba5d10345b1be14adc1942/gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java#L89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
