Will-Lo commented on code in PR #3837:
URL: https://github.com/apache/gobblin/pull/3837#discussion_r1408239869
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -266,7 +270,7 @@ public void orchestrate(Spec spec, Properties jobProps,
long triggerTimestampMil
return;
}
- String flowExecutionId =
flowMetadata.get(TimingEvent.FlowEventConstants.FLOW_EXECUTION_ID_FIELD);
+ String flowExecutionId =
TimingEventUtils.getFlowExecutionIdFromFlowMetadata(flowMetadata);
Review Comment:
What's the motivation behind changing this function here? From my point of
view we should be enforcing the existence of a flow execution ID here as a dag
must have an associated flow execution ID, otherwise we should block
progression as the dag is likely corrupt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
