umustafi commented on code in PR #3837:
URL: https://github.com/apache/gobblin/pull/3837#discussion_r1408245237
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -266,7 +270,7 @@ public void orchestrate(Spec spec, Properties jobProps,
long triggerTimestampMil
return;
}
- String flowExecutionId =
flowMetadata.get(TimingEvent.FlowEventConstants.FLOW_EXECUTION_ID_FIELD);
+ String flowExecutionId =
TimingEventUtils.getFlowExecutionIdFromFlowMetadata(flowMetadata);
Review Comment:
Ah I see, I changed this to abstract away the use of the key. I could update
the function to not provide a default if one doesn't exist, always expecting
existence of flow execution id or revert this. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
