phet commented on code in PR #3837:
URL: https://github.com/apache/gobblin/pull/3837#discussion_r1409731892


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/TimingEventUtils.java:
##########
@@ -47,6 +47,13 @@ static Map<String, String> getFlowMetadata(Config 
flowConfig) {
     return metadata;
   }
 
+  /**
+   * Retrieves a flowExecutionId from flowMetadata map and returns dummy value 
if one is not set
+   */
+  public static String getFlowExecutionIdFromFlowMetadata(Map<String, String> 
flowMetadata) {
+    return 
flowMetadata.getOrDefault(TimingEvent.FlowEventConstants.FLOW_EXECUTION_ID_FIELD,
 "<<no flowExecutionId>>");
+  }

Review Comment:
   makes sense.  I now see that the `DagManagerUtils` is unfortunately only 
applicable to that specific context... not also here... :(
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to