[
https://issues.apache.org/jira/browse/GOBBLIN-1910?focusedWorklogId=898506&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898506
]
ASF GitHub Bot logged work on GOBBLIN-1910:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jan/24 17:50
Start Date: 08/Jan/24 17:50
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3853:
URL: https://github.com/apache/gobblin/pull/3853#discussion_r1445037002
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagerUtils.java:
##########
@@ -366,4 +396,63 @@ static List<String> getDistinctUniqueRequesters(String
serializedRequesters) {
throw new RuntimeException("Could not process requesters due to ", e);
}
}
+
+ public static void
submitInitializationEventsAndSetStatus(Dag<JobExecutionPlan> dag,
Optional<EventSubmitter> eventSubmitter) {
Review Comment:
given the entire body is skipped when absent (e.g. you don't even set status
when not submitting), it may be clearer to phrase as:
```
submitAndSet(Dag<JEP> dag, EventSubmitter es)
```
for use as:
```
eventSubmitter.ifPresent(es -> submitAndSet(dag, es));
```
to promote that, let's rid ourselves of the antiquated guava `Optional` in
favor of the java8 one
Issue Time Tracking
-------------------
Worklog Id: (was: 898506)
Time Spent: 15h (was: 14h 50m)
> Refactor code to move current in-memory references to new design for REST
> calls: Launch, Resume and Kill
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1910
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1910
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 15h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
