[
https://issues.apache.org/jira/browse/GOBBLIN-1910?focusedWorklogId=898800&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898800
]
ASF GitHub Bot logged work on GOBBLIN-1910:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/24 22:42
Start Date: 09/Jan/24 22:42
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3853:
URL: https://github.com/apache/gobblin/pull/3853#discussion_r1446695682
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/Dag.java:
##########
@@ -255,10 +261,14 @@ public static class DagNode<T> {
private T value;
//List of parent Nodes that are dependencies of this Node.
private List<DagNode<T>> parentNodes;
+ private String id;
//Constructor
public DagNode(T value) {
this.value = value;
+ if (this.getValue() instanceof JobExecutionPlan) {
+ this.id = createId(((JobExecutionPlan)
this.getValue()).getJobSpec().getConfig());
+ }
Review Comment:
Sounds fair. It should be a part of JobExecutionPlan, moved it there.
Issue Time Tracking
-------------------
Worklog Id: (was: 898800)
Time Spent: 15h 50m (was: 15h 40m)
> Refactor code to move current in-memory references to new design for REST
> calls: Launch, Resume and Kill
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1910
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1910
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 15h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
