[
https://issues.apache.org/jira/browse/GOBBLIN-1910?focusedWorklogId=898834&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898834
]
ASF GitHub Bot logged work on GOBBLIN-1910:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/24 01:53
Start Date: 10/Jan/24 01:53
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3853:
URL: https://github.com/apache/gobblin/pull/3853#discussion_r1446798677
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagerUtils.java:
##########
@@ -397,15 +390,15 @@ static List<String> getDistinctUniqueRequesters(String
serializedRequesters) {
}
}
- public static void
submitInitializationEventsAndSetStatus(Dag<JobExecutionPlan> dag,
Optional<EventSubmitter> eventSubmitter) {
- if (eventSubmitter.isPresent()) {
+ public static void submitAndSet(Dag<JobExecutionPlan> dag,
Optional<EventSubmitter> eventSubmitter) {
Review Comment:
what did you think of my prior suggestion to lift the conditional processing
out of this method? instead it would always take action and we'd leave it to
the caller to evaluate the `Optional<EventSubmitter>` and decide whether or not
to call this method
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -338,7 +338,7 @@ public synchronized void addDag(Dag<JobExecutionPlan> dag,
boolean persist, bool
throw new IOException("Could not add dag" + dagId + "to queue");
}
if (setStatus) {
- DagManagerUtils.submitInitializationEventsAndSetStatus(dag,
this.eventSubmitter);
+ DagManagerUtils.submitAndSet(dag, this.eventSubmitter);
Review Comment:
reading it used here, it would be clearer if named `submitPendingExecStatus
Issue Time Tracking
-------------------
Worklog Id: (was: 898834)
Time Spent: 16h 20m (was: 16h 10m)
> Refactor code to move current in-memory references to new design for REST
> calls: Launch, Resume and Kill
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1910
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1910
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 16h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
