[
https://issues.apache.org/jira/browse/GOBBLIN-2040?focusedWorklogId=915191&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915191
]
ASF GitHub Bot logged work on GOBBLIN-2040:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/24 18:57
Start Date: 17/Apr/24 18:57
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3919:
URL: https://github.com/apache/gobblin/pull/3919#discussion_r1569339137
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/watermark/StringWatermark.java:
##########
@@ -26,19 +26,22 @@
import lombok.AllArgsConstructor;
import lombok.EqualsAndHashCode;
-import lombok.Getter;
/**
* String based {@link ComparableWatermark} implementation.
*/
@AllArgsConstructor
@EqualsAndHashCode
-public class StringWatermark implements ComparableWatermark {
+public class StringWatermark implements ComparableWatermark<String> {
Review Comment:
There is no API change in this class at all. i.e. the getValue still return
String type and the way to construct the class still remain the same. So I
think we don't need test for this part. Let me know if you still have concerns
about this.
Issue Time Tracking
-------------------
Worklog Id: (was: 915191)
Time Spent: 0.5h (was: 20m)
> Abstract comparable watermark
> -----------------------------
>
> Key: GOBBLIN-2040
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2040
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Create Abstract GobblinConsumerClass to support different type of offset and
> watermark
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
