[
https://issues.apache.org/jira/browse/GOBBLIN-2040?focusedWorklogId=916512&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916512
]
ASF GitHub Bot logged work on GOBBLIN-2040:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/24 20:15
Start Date: 25/Apr/24 20:15
Worklog Time Spent: 10m
Work Description: linweihs commented on code in PR #3935:
URL: https://github.com/apache/gobblin/pull/3935#discussion_r1580073146
##########
gobblin-api/src/main/java/org/apache/gobblin/source/extractor/ComparableWatermark.java:
##########
@@ -20,7 +20,7 @@
/**
* {@link Watermark} that is also {@link Comparable}.
*/
-public interface ComparableWatermark<V extends Comparable<V>> extends
Watermark, Comparable<ComparableWatermark>{
+public interface ComparableWatermark<V> extends Watermark,
Comparable<ComparableWatermark>{
Review Comment:
Would this break other existing use case that have already implements the
interface ?
or Is creating a new interface have a clean start ?
Issue Time Tracking
-------------------
Worklog Id: (was: 916512)
Time Spent: 1.5h (was: 1h 20m)
> Abstract comparable watermark
> -----------------------------
>
> Key: GOBBLIN-2040
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2040
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Create Abstract GobblinConsumerClass to support different type of offset and
> watermark
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
