[
https://issues.apache.org/jira/browse/GOBBLIN-2040?focusedWorklogId=915232&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915232
]
ASF GitHub Bot logged work on GOBBLIN-2040:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Apr/24 05:24
Start Date: 18/Apr/24 05:24
Worklog Time Spent: 10m
Work Description: ShubhamGupta29 commented on code in PR #3919:
URL: https://github.com/apache/gobblin/pull/3919#discussion_r1569998014
##########
gobblin-core-base/src/main/java/org/apache/gobblin/source/extractor/extract/LongWatermark.java:
##########
@@ -29,20 +29,23 @@
import org.apache.gobblin.source.extractor.Watermark;
import lombok.EqualsAndHashCode;
-import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
@ToString
@EqualsAndHashCode
-public class LongWatermark implements ComparableWatermark {
+public class LongWatermark implements ComparableWatermark<Long> {
Review Comment:
nit: Missing JavaDoc.
Issue Time Tracking
-------------------
Worklog Id: (was: 915232)
Time Spent: 50m (was: 40m)
> Abstract comparable watermark
> -----------------------------
>
> Key: GOBBLIN-2040
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2040
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Create Abstract GobblinConsumerClass to support different type of offset and
> watermark
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
