[
https://issues.apache.org/jira/browse/GOBBLIN-2050?focusedWorklogId=916259&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916259
]
ASF GitHub Bot logged work on GOBBLIN-2050:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Apr/24 21:33
Start Date: 24/Apr/24 21:33
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3931:
URL: https://github.com/apache/gobblin/pull/3931#discussion_r1578543298
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/GaaSObservabilityEventProducer.java:
##########
@@ -99,6 +99,7 @@ protected OpenTelemetryMetricsBase
getOpentelemetryMetrics(State state) {
private void setupMetrics(State state) {
this.opentelemetryMetrics = getOpentelemetryMetrics(state);
if (this.opentelemetryMetrics != null) {
+ log.info("Setting up Opentelemetry metrics");
Review Comment:
did these changes sneak in?
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java:
##########
@@ -50,6 +50,8 @@ public class GobblinClusterConfigurationKeys {
public static final boolean DEFAULT_STANDALONE_CLUSTER_MODE = false;
// Root working directory for Gobblin cluster
public static final String CLUSTER_WORK_DIR = GOBBLIN_CLUSTER_PREFIX +
"workDir";
+ // Root working dir without appending the application name, keeping
CLUSTER_WORK_DIR property for backward compatibility
Review Comment:
documenting an example might help illustrate the semantic difference between
the two props (and let people decide when they want each).
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java:
##########
@@ -885,10 +884,11 @@ private AbstractTokenRefresher buildTokenRefreshManager()
throws IOException {
@VisibleForTesting
void cleanUpAppWorkDirectory(ApplicationId applicationId) throws IOException
{
- Path appWorkDir =
GobblinClusterUtils.getAppWorkDirPathFromConfig(this.config, this.fs,
this.applicationName, applicationId.toString());
- if (this.fs.exists(appWorkDir)) {
+ FileSystem fs =
GobblinClusterUtils.buildNewInstanceFileSystem(this.config,
this.yarnConfiguration);
Review Comment:
let's document that we found the other FS instance was closed by the YARN
app and couldn't be reused!
Issue Time Tracking
-------------------
Worklog Id: (was: 916259)
Time Spent: 2h 10m (was: 2h)
> Allow configurable token file paths and cluster work directories to allow for
> easy cleanup after yarn app closes
> ----------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2050
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2050
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Gobblin Yarn Application Launcher has some issues where directories used for
> the job can persist after the job ends. It also creates a number of temporary
> files which can grow out of control.
> We want to be able to:
> 1. Clean up directories effectively
> 2. Use explicit paths to allow for consolidation of temp files to be under
> the same folder for token renewal and cluster work files.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
