[
https://issues.apache.org/jira/browse/GOBBLIN-2050?focusedWorklogId=916267&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916267
]
ASF GitHub Bot logged work on GOBBLIN-2050:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Apr/24 22:08
Start Date: 24/Apr/24 22:08
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3931:
URL: https://github.com/apache/gobblin/pull/3931#discussion_r1578579697
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java:
##########
@@ -885,10 +884,11 @@ private AbstractTokenRefresher buildTokenRefreshManager()
throws IOException {
@VisibleForTesting
void cleanUpAppWorkDirectory(ApplicationId applicationId) throws IOException
{
- Path appWorkDir =
GobblinClusterUtils.getAppWorkDirPathFromConfig(this.config, this.fs,
this.applicationName, applicationId.toString());
- if (this.fs.exists(appWorkDir)) {
+ FileSystem fs =
GobblinClusterUtils.buildNewInstanceFileSystem(this.config,
this.yarnConfiguration);
Review Comment:
what do you think here?
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterUtils.java:
##########
@@ -254,4 +257,13 @@ public static FileSystem buildFileSystem(Config config,
Configuration conf)
.get(URI.create(config.getString(ConfigurationKeys.FS_URI_KEY)), conf)
: FileSystem.get(conf);
}
+
+ public static FileSystem buildNewInstanceFileSystem(Config config,
Configuration conf) throws IOException {
Review Comment:
nit: `createFileSystem`?
Issue Time Tracking
-------------------
Worklog Id: (was: 916267)
Time Spent: 2.5h (was: 2h 20m)
> Allow configurable token file paths and cluster work directories to allow for
> easy cleanup after yarn app closes
> ----------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2050
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2050
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Gobblin Yarn Application Launcher has some issues where directories used for
> the job can persist after the job ends. It also creates a number of temporary
> files which can grow out of control.
> We want to be able to:
> 1. Clean up directories effectively
> 2. Use explicit paths to allow for consolidation of temp files to be under
> the same folder for token renewal and cluster work files.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
