[
https://issues.apache.org/jira/browse/GOBBLIN-2050?focusedWorklogId=916288&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916288
]
ASF GitHub Bot logged work on GOBBLIN-2050:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/24 01:18
Start Date: 25/Apr/24 01:18
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3931:
URL: https://github.com/apache/gobblin/pull/3931#issuecomment-2076131502
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3931?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
Attention: Patch coverage is `22.22222%` with `7 lines` in your changes are
missing coverage. Please review.
> Project coverage is 41.20%. Comparing base
[(`1ca4944`)](https://app.codecov.io/gh/apache/gobblin/commit/1ca4944359fae3a7348a56427a2c38555811e977?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`a194440`)](https://app.codecov.io/gh/apache/gobblin/pull/3931?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 14 commits behind head on master.
|
[Files](https://app.codecov.io/gh/apache/gobblin/pull/3931?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...rg/apache/gobblin/cluster/GobblinClusterUtils.java](https://app.codecov.io/gh/apache/gobblin/pull/3931?src=pr&el=tree&filepath=gobblin-cluster%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Fcluster%2FGobblinClusterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJVdGlscy5qYXZh)
| 22.22% | [6 Missing and 1 partial :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3931?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3931 +/- ##
============================================
- Coverage 46.63% 41.20% -5.43%
+ Complexity 11247 2193 -9054
============================================
Files 2248 475 -1773
Lines 88520 20214 -68306
Branches 9701 2342 -7359
============================================
- Hits 41278 8329 -32949
+ Misses 43510 10999 -32511
+ Partials 3732 886 -2846
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3931?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 916288)
Time Spent: 2h 40m (was: 2.5h)
> Allow configurable token file paths and cluster work directories to allow for
> easy cleanup after yarn app closes
> ----------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2050
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2050
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Gobblin Yarn Application Launcher has some issues where directories used for
> the job can persist after the job ends. It also creates a number of temporary
> files which can grow out of control.
> We want to be able to:
> 1. Clean up directories effectively
> 2. Use explicit paths to allow for consolidation of temp files to be under
> the same folder for token renewal and cluster work files.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
