[
https://issues.apache.org/jira/browse/GOBBLIN-2069?focusedWorklogId=919923&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-919923
]
ASF GitHub Bot logged work on GOBBLIN-2069:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/24 22:02
Start Date: 17/May/24 22:02
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3950:
URL: https://github.com/apache/gobblin/pull/3950#discussion_r1605574480
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -162,12 +220,16 @@ private DagTask createDagTask(DagActionStore.DagAction
dagAction, LeaseAttemptSt
DagActionStore.DagActionType dagActionType = dagAction.getDagActionType();
switch (dagActionType) {
+ case ENFORCE_FINISH_DEADLINE:
+ return new EnforceFinishDeadlineDagTask(dagAction,
leaseObtainedStatus, dagActionStore.get());
+ case ENFORCE_START_DEADLINE:
+ return new EnforceStartDeadlineDagTask(dagAction, leaseObtainedStatus,
dagActionStore.get());
Review Comment:
start and finish are typically complements, but that's not the case here,
correct? rather its "job start" and "flow finish".
first off, please add the job or flow qualifier into all of these names -
for: action type, `DagTask`, `DagProc`, etc..
secondly, shall we work to prevent any start vs. finish confusion (from them
operating on different entity levels) by rename to `flowCompletionDeadline`?
Issue Time Tracking
-------------------
Worklog Id: (was: 919923)
Time Spent: 50m (was: 40m)
> implement EnforceStartDeadlineDagProc
> -------------------------------------
>
> Key: GOBBLIN-2069
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2069
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
