[
https://issues.apache.org/jira/browse/GOBBLIN-2069?focusedWorklogId=919924&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-919924
]
ASF GitHub Bot logged work on GOBBLIN-2069:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/24 22:02
Start Date: 17/May/24 22:02
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3950:
URL: https://github.com/apache/gobblin/pull/3950#discussion_r1605575625
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagActionStore.java:
##########
@@ -69,6 +72,10 @@ public DagNodeId getDagNodeId() {
return new DagNodeId(this.flowGroup, this.flowName,
Long.parseLong(this.flowExecutionId), this.flowGroup, this.jobName);
}
+
+ public void setReminder(boolean isReminder) {
Review Comment:
I actually wouldn't have expected `@Setter` to be necessary, given the
`@Data` and the non-`final` field
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagActionStore.java:
##########
@@ -69,6 +72,10 @@ public DagNodeId getDagNodeId() {
return new DagNodeId(this.flowGroup, this.flowName,
Long.parseLong(this.flowExecutionId), this.flowGroup, this.jobName);
}
+
+ public void setReminder(boolean isReminder) {
Review Comment:
I actually wouldn't have expected `@Setter` to be necessary, given the
`@Data` with the non-`final` field
Issue Time Tracking
-------------------
Worklog Id: (was: 919924)
Time Spent: 1h (was: 50m)
> implement EnforceStartDeadlineDagProc
> -------------------------------------
>
> Key: GOBBLIN-2069
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2069
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
