[
https://issues.apache.org/jira/browse/GOBBLIN-2069?focusedWorklogId=920077&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-920077
]
ASF GitHub Bot logged work on GOBBLIN-2069:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/May/24 17:21
Start Date: 20/May/24 17:21
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3950:
URL: https://github.com/apache/gobblin/pull/3950#discussion_r1607040186
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -124,9 +135,16 @@ public DagTask next() {
while (true) {
try {
DagActionStore.DagAction dagAction = this.dagActionQueue.take();
- LeaseAttemptStatus leaseAttemptStatus =
retrieveLeaseStatus(dagAction);
- if (leaseAttemptStatus instanceof
LeaseAttemptStatus.LeaseObtainedStatus) {
- return createDagTask(dagAction,
(LeaseAttemptStatus.LeaseObtainedStatus) leaseAttemptStatus);
+ // create triggers for original (non-reminder) dag actions of type
ENFORCE_START_DEADLINE and ENFORCE_FINISH_DEADLINE
Review Comment:
nit: update the names here to be ENFORCE_JOB_START and ENFORCE_FLOW_FINISH...
this comment is not insightful enough because we can see the triggers are
created instead
`reminder triggers are used to inform hosts once the deadline for
ENFORCE_JOB_START and ENFORCE_FLOW_FINISH... passes. then only is lease
arbitration done to enforce the deadline violation and fail the job or flow if
needed`
Issue Time Tracking
-------------------
Worklog Id: (was: 920077)
Time Spent: 2.5h (was: 2h 20m)
> implement EnforceStartDeadlineDagProc
> -------------------------------------
>
> Key: GOBBLIN-2069
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2069
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
