phet commented on code in PR #3997:
URL: https://github.com/apache/gobblin/pull/3997#discussion_r1671665510
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagement.java:
##########
@@ -26,14 +26,8 @@
* Consumption of the Dags happen through {@link DagTaskStream}.
*/
public interface DagManagement {
-
- /**
- * Used to add a dagAction event to DagManagement
- */
- void addDagAction(DagActionStore.DagAction dagAction) throws IOException;
-
/**
- * Used to add reminder dagActions to the queue that already contain an
eventTimestamp from the previous lease attempt
+ * Used to add {@link DagActionStore.LeaseParams} to the queue that already
contain an eventTimestamp from the previous lease attempt
*/
- void addReminderDagAction(DagActionStore.LeaseParams reminderLeaseParams)
throws IOException;
+ void addDagAction(DagActionStore.LeaseParams reminderLeaseParams) throws
IOException;
Review Comment:
should the param still be named `reminder...`?
also (javadoc) - in the general case, it doesn't necessarily "already
contain ... from the prev. lease attempt"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
