arjun4084346 commented on code in PR #3997: URL: https://github.com/apache/gobblin/pull/3997#discussion_r1672691544
########## gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java: ########## @@ -120,6 +123,7 @@ public abstract class KafkaJobStatusMonitor extends HighLevelConsumer<byte[], by private final GaaSJobObservabilityEventProducer eventProducer; private final DagManagementStateStore dagManagementStateStore; private final boolean dagProcEngineEnabled; + private final List<Class<? extends Exception>> nonTransientExceptions = Collections.singletonList(SQLIntegrityConstraintViolationException.class); Review Comment: how about nonRetryableExceptions ? because that's the purpose this list is serving - deciding to retry or not. permitted/allowed gives a sense like the exceptions are not something to worry about at all -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
