arjun4084346 commented on code in PR #3997:
URL: https://github.com/apache/gobblin/pull/3997#discussion_r1672712133
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/MysqlDagActionStoreTest.java:
##########
@@ -70,17 +70,6 @@ public static DagActionStore
getTestDagActionStore(ITestMetastoreDatabase testDb
return new MysqlDagActionStore(config);
}
- @Test
- public void testAddAction() throws Exception {
- this.mysqlDagActionStore.addJobDagAction(flowGroup, flowName,
flowExecutionId, jobName, DagActionStore.DagActionType.KILL);
- //Should not be able to add KILL again when previous one exist
- Assert.expectThrows(IOException.class,
- () -> this.mysqlDagActionStore.addJobDagAction(flowGroup, flowName,
flowExecutionId, jobName, DagActionStore.DagActionType.KILL));
- //Should be able to add a RESUME action for same execution as well as KILL
for another execution of the flow
- this.mysqlDagActionStore.addJobDagAction(flowGroup, flowName,
flowExecutionId, jobName, DagActionStore.DagActionType.RESUME);
- this.mysqlDagActionStore.addJobDagAction(flowGroup, flowName,
flowExecutionId_2, jobName, DagActionStore.DagActionType.KILL);
- }
-
Review Comment:
it needed to be removed when in earlier commit when i was changing the
behavior of dag action store to accept duplicate entries and not throw
exception. adding it back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
