[
https://issues.apache.org/jira/browse/GOBBLIN-2115?focusedWorklogId=926531&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926531
]
ASF GitHub Bot logged work on GOBBLIN-2115:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/24 19:14
Start Date: 18/Jul/24 19:14
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3999:
URL: https://github.com/apache/gobblin/pull/3999#discussion_r1683358678
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementStateStore.java:
##########
@@ -42,6 +41,8 @@
* An interface to provide abstractions for managing {@link Dag} and {@link
org.apache.gobblin.service.modules.flowgraph.Dag.DagNode} states
* and allows add/delete and other functions.
*/
+// todo - this should merge with DagStateStoreWithDagNodes interface and
`addDagNodeState` and `addDagNode` should merge and rename to
Review Comment:
they are separate entities. `DagManagementStateStore` encompasses all the
things we persist - DagStates/DagNodeStates, DagActions, UserQuotas, FlowSpecs
Issue Time Tracking
-------------------
Worklog Id: (was: 926531)
Time Spent: 20m (was: 10m)
> implement fully mysql based DMSS
> --------------------------------
>
> Key: GOBBLIN-2115
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2115
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
