[ 
https://issues.apache.org/jira/browse/GOBBLIN-2115?focusedWorklogId=926541&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926541
 ]

ASF GitHub Bot logged work on GOBBLIN-2115:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Jul/24 19:40
            Start Date: 18/Jul/24 19:40
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #3999:
URL: https://github.com/apache/gobblin/pull/3999#discussion_r1683386592


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/ReevaluateDagProc.java:
##########
@@ -167,9 +160,5 @@ private void onJobFinish(DagManagementStateStore 
dagManagementStateStore, Dag.Da
       default:
         log.warn("It should not reach here. Job status {} is unexpected.", 
executionStatus);
     }
-
-    // Checkpoint the dag state, it should have an updated value of dag fields
-    dagManagementStateStore.checkpointDag(dag);

Review Comment:
   yes. only setMessage and setFlowEvent are called, which are anyway not 
persisted anyway





Issue Time Tracking
-------------------

    Worklog Id:     (was: 926541)
    Time Spent: 1h 40m  (was: 1.5h)

> implement fully mysql based DMSS
> --------------------------------
>
>                 Key: GOBBLIN-2115
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2115
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to