[ 
https://issues.apache.org/jira/browse/GOBBLIN-2115?focusedWorklogId=926540&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926540
 ]

ASF GitHub Bot logged work on GOBBLIN-2115:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Jul/24 19:39
            Start Date: 18/Jul/24 19:39
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #3999:
URL: https://github.com/apache/gobblin/pull/3999#discussion_r1683385416


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProc.java:
##########
@@ -84,8 +84,6 @@ protected void act(DagManagementStateStore 
dagManagementStateStore, Optional<Dag
       // todo - add metrics
     } else {
       DagProcUtils.submitNextNodes(dagManagementStateStore, dag.get(), 
getDagId());
-      // Checkpoint the dag state, it should have an updated value of dag nodes

Review Comment:
   because DagProcUtils.submitNextNodes updates the table already





Issue Time Tracking
-------------------

    Worklog Id:     (was: 926540)
    Time Spent: 1.5h  (was: 1h 20m)

> implement fully mysql based DMSS
> --------------------------------
>
>                 Key: GOBBLIN-2115
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2115
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to