[
https://issues.apache.org/jira/browse/GOBBLIN-2115?focusedWorklogId=926555&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926555
]
ASF GitHub Bot logged work on GOBBLIN-2115:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/24 20:27
Start Date: 18/Jul/24 20:27
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3999:
URL: https://github.com/apache/gobblin/pull/3999#discussion_r1683445002
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MysqlDagActionStore.java:
##########
@@ -49,26 +48,22 @@ public class MysqlDagActionStore implements DagActionStore {
protected final DataSource dataSource;
private final DBStatementExecutor dbStatementExecutor;
private final String tableName;
- private final long retentionPeriodSeconds;
- private String thisTableRetentionStatement;
private static final String EXISTS_STATEMENT = "SELECT EXISTS(SELECT * FROM
%s WHERE flow_group = ? AND flow_name = ? AND flow_execution_id = ? AND
job_name = ? AND dag_action = ?)";
protected static final String INSERT_STATEMENT = "INSERT INTO %s
(flow_group, flow_name, flow_execution_id, job_name, dag_action) "
+ "VALUES (?, ?, ?, ?, ?)";
private static final String DELETE_STATEMENT = "DELETE FROM %s WHERE
flow_group = ? AND flow_name =? AND flow_execution_id = ? AND job_name = ? AND
dag_action = ?";
- private static final String GET_STATEMENT = "SELECT flow_group, flow_name,
flow_execution_id, job_name, dag_action FROM %s WHERE flow_group = ? AND
flow_name =? AND flow_execution_id = ? AND job_name = ? AND dag_action = ?";
Review Comment:
no one dag action is never desired... only requirement is to load all the
dag actions in the beginning
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MysqlDagActionStore.java:
##########
@@ -49,26 +48,22 @@ public class MysqlDagActionStore implements DagActionStore {
protected final DataSource dataSource;
private final DBStatementExecutor dbStatementExecutor;
private final String tableName;
- private final long retentionPeriodSeconds;
- private String thisTableRetentionStatement;
private static final String EXISTS_STATEMENT = "SELECT EXISTS(SELECT * FROM
%s WHERE flow_group = ? AND flow_name = ? AND flow_execution_id = ? AND
job_name = ? AND dag_action = ?)";
protected static final String INSERT_STATEMENT = "INSERT INTO %s
(flow_group, flow_name, flow_execution_id, job_name, dag_action) "
+ "VALUES (?, ?, ?, ?, ?)";
private static final String DELETE_STATEMENT = "DELETE FROM %s WHERE
flow_group = ? AND flow_name =? AND flow_execution_id = ? AND job_name = ? AND
dag_action = ?";
- private static final String GET_STATEMENT = "SELECT flow_group, flow_name,
flow_execution_id, job_name, dag_action FROM %s WHERE flow_group = ? AND
flow_name =? AND flow_execution_id = ? AND job_name = ? AND dag_action = ?";
Review Comment:
no, one dag action is never desired... only requirement is to load all the
dag actions in the beginning
Issue Time Tracking
-------------------
Worklog Id: (was: 926555)
Time Spent: 2h 40m (was: 2.5h)
> implement fully mysql based DMSS
> --------------------------------
>
> Key: GOBBLIN-2115
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2115
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
