[
https://issues.apache.org/jira/browse/GOBBLIN-976?focusedWorklogId=347815&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347815
]
ASF GitHub Bot logged work on GOBBLIN-976:
------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/19 00:07
Start Date: 22/Nov/19 00:07
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2823: GOBBLIN-976:
Add dynamic config to the state before instantiating met…
URL: https://github.com/apache/incubator-gobblin/pull/2823
…rics reporter in MRJobLauncher
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-976
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
To properly instantiate metric reporter, the dynamic config generated via
dynamicConfigGenerator.classes needs to be added into the state object passed
to the reporter.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Tested with an end-to-end pipeline.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 347815)
Remaining Estimate: 0h
Time Spent: 10m
> Add dynamic config to the state before instantiating metrics reporter in
> MRJobLauncher
> --------------------------------------------------------------------------------------
>
> Key: GOBBLIN-976
> URL: https://issues.apache.org/jira/browse/GOBBLIN-976
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> To properly instantiate metric reporter, the dynamic config generated via
> dynamicConfigGenerator.classes needs to be added into the state object passed
> to the reporter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
