[
https://issues.apache.org/jira/browse/GOBBLIN-976?focusedWorklogId=347838&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347838
]
ASF GitHub Bot logged work on GOBBLIN-976:
------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/19 00:41
Start Date: 22/Nov/19 00:41
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2823: GOBBLIN-976: Add
dynamic config to the state before instantiating met…
URL:
https://github.com/apache/incubator-gobblin/pull/2823#issuecomment-557336417
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2823?src=pr&el=h1)
Report
> Merging
[#2823](https://codecov.io/gh/apache/incubator-gobblin/pull/2823?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/9f50a2563cc257039da44018663b6b9e119fb499?src=pr&el=desc)
will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2823?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2823 +/- ##
===========================================
- Coverage 45.61% 45.6% -0.02%
+ Complexity 8969 8966 -3
===========================================
Files 1902 1902
Lines 71272 71273 +1
Branches 7863 7863
===========================================
- Hits 32511 32503 -8
- Misses 35770 35776 +6
- Partials 2991 2994 +3
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2823?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...pache/gobblin/runtime/mapreduce/MRJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2823/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL01SSm9iTGF1bmNoZXIuamF2YQ==)
| `53.05% <100%> (+0.12%)` | `19 <0> (ø)` | :arrow_down: |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2823/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `35.51% <0%> (-3.74%)` | `12% <0%> (-1%)` | |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2823/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `70% <0%> (-2.23%)` | `13% <0%> (ø)` | |
|
[.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2823/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh)
| `78.12% <0%> (-1.57%)` | `15% <0%> (-1%)` | |
|
[...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2823/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh)
| `59.09% <0%> (-1.52%)` | `14% <0%> (-1%)` | |
|
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2823/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `61.42% <0%> (-1.43%)` | `4% <0%> (ø)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2823?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2823?src=pr&el=footer).
Last update
[9f50a25...b72d3bc](https://codecov.io/gh/apache/incubator-gobblin/pull/2823?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 347838)
Time Spent: 50m (was: 40m)
> Add dynamic config to the state before instantiating metrics reporter in
> MRJobLauncher
> --------------------------------------------------------------------------------------
>
> Key: GOBBLIN-976
> URL: https://issues.apache.org/jira/browse/GOBBLIN-976
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> To properly instantiate metric reporter, the dynamic config generated via
> dynamicConfigGenerator.classes needs to be added into the state object passed
> to the reporter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
