[
https://issues.apache.org/jira/browse/GOBBLIN-976?focusedWorklogId=347820&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347820
]
ASF GitHub Bot logged work on GOBBLIN-976:
------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/19 00:15
Start Date: 22/Nov/19 00:15
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2823: GOBBLIN-976:
Add dynamic config to the state before instantiating met…
URL: https://github.com/apache/incubator-gobblin/pull/2823#discussion_r349381535
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/mapreduce/MRJobLauncher.java
##########
@@ -766,6 +767,7 @@ protected void setup(Context context) {
for (Map.Entry<String, ConfigValue> entry : dynamicConfig.entrySet()) {
this.jobState.setProp(entry.getKey(),
entry.getValue().unwrapped().toString());
configuration.set(entry.getKey(),
entry.getValue().unwrapped().toString());
+ gobblinJobState.setProp(entry.getKey(),
entry.getValue().unwrapped().toString());
Review comment:
Is there anyway to only keep `gobblinJobState` here, instead of have
`configuration` object and `gobblinJobState` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 347820)
Time Spent: 20m (was: 10m)
> Add dynamic config to the state before instantiating metrics reporter in
> MRJobLauncher
> --------------------------------------------------------------------------------------
>
> Key: GOBBLIN-976
> URL: https://issues.apache.org/jira/browse/GOBBLIN-976
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> To properly instantiate metric reporter, the dynamic config generated via
> dynamicConfigGenerator.classes needs to be added into the state object passed
> to the reporter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
