[ 
https://issues.apache.org/jira/browse/GORA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052552#comment-14052552
 ] 

Lewis John McGibbney commented on GORA-346:
-------------------------------------------

Hi [~antiguru], I just checked out a fresh copy from git-wip applied your patch 
and build successfully so that ticksone box.
 * I think thay building with Hadoop 2.4.0 by default is OK and is certainly a 
huge step in the right direction. 
 * It is backwards compatable. 
 * We are using Avro 1.7.6 whereas Hadoop relies on 1.7.4 now so that ties in 
nicely as well.
 * I do see that we build with some deprecation being indicated by the 
compiler...  but hey whats new ;) we can deal with that in another patch which 
can be the successor to this issue.
 * Honestly, my main issue with this patch is that we need to accompany it with 
sufficient documentation... honestly that is my main issue. I am more than 
willing to put time into that aspect of the patch.
 * I see that the Maven packaging for new modules is set to jar as oppose to 
bundles. Can we clarify if this is OK.
 * FInally, are we going to distribute these artefacts?
Thanks for this patch.


> Create shim layer to support multiple hadoop versions
> -----------------------------------------------------
>
>                 Key: GORA-346
>                 URL: https://issues.apache.org/jira/browse/GORA-346
>             Project: Apache Gora
>          Issue Type: Improvement
>    Affects Versions: 0.5
>            Reporter: Renato Javier MarroquĂ­n Mogrovejo
>            Assignee: Moritz Hoffmann
>              Labels: patch
>         Attachments: GORA-346_v1.patch, GORA-346_v2.patch, GORA-346_v3.patch, 
> GORA-346_v4_profiles.patch, GORA-346_v5.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to