[
https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14058559#comment-14058559
]
Renato Javier Marroquín Mogrovejo commented on GORA-354:
--------------------------------------------------------
Hey guys,
I think Tyler's suggestion to move this into the getProperty is right, but I
don't think we add this double check on the property as the property's names
should be in lowercase and we should enforce that users do that (as we use the
properties this way inside Gora). I mean it's fine double checking, but it's an
extra IF for nothing, that we would have to do every time we request for a
property, even if this is not initialization phase. That is just my 2c.
> Clarify lowercasing of DataStoreFactory#findProperty
> ----------------------------------------------------
>
> Key: GORA-354
> URL: https://issues.apache.org/jira/browse/GORA-354
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-core
> Affects Versions: 0.5
> Reporter: Lewis John McGibbney
> Assignee: Tyler Palsulich
> Priority: Critical
> Fix For: 0.5
>
> Attachments: GORA-354.palsulich.070914.patch, GORA-354.unit-test.patch
>
>
> Right now it appears that the reading of key's and value's from
> DataStoreFactory#findProperty is a process which does not lowercase keys or
> values.
> This can result in undesired behavhiour meaning that configuration properties
> are not used properly @Runtime.
> The fix should be a lowercasing of all properties so that they can be stored
> within and read from the call to System properties.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
