[ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062004#comment-14062004 ]
Lewis John McGibbney commented on GORA-354: ------------------------------------------- Looks good to me folks. The only concern I have is with the non-related removal of Maven config from parent pom.xml. Any other comments? > Clarify lowercasing of DataStoreFactory#findProperty > ---------------------------------------------------- > > Key: GORA-354 > URL: https://issues.apache.org/jira/browse/GORA-354 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core > Affects Versions: 0.5 > Reporter: Lewis John McGibbney > Assignee: Tyler Palsulich > Priority: Critical > Fix For: 0.5 > > Attachments: GORA-354.palsulich.070914.patch, > GORA-354.palsulich.071414.full.patch, GORA-354.unit-test.patch > > > Right now it appears that the reading of key's and value's from > DataStoreFactory#findProperty is a process which does not lowercase keys or > values. > This can result in undesired behavhiour meaning that configuration properties > are not used properly @Runtime. > The fix should be a lowercasing of all properties so that they can be stored > within and read from the call to System properties. -- This message was sent by Atlassian JIRA (v6.2#6252)