[
https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062037#comment-14062037
]
Renato Javier Marroquín Mogrovejo commented on GORA-354:
--------------------------------------------------------
Hi guys,
Sorry to take so long to get to this. My comments are:
1) properties.getProperty(key.toLowerCase()); IMHO this should be called only
once with the lowerCase, and if this is wrong then then user should be notified
that he is doing something wrong (which he is). So maybe doing the conversion
on the getProperty method? wdty [~lewismc]?
2) I like the unit tests ;) great work [~tpalsulich]!
3) I'd rather have only standard comments, not in this format:
String result = properties.getProperty(key); // Try to get the property with
the specified case.
4) Yeah about the testFailureIgnore, let's look at that in the other opened
JIRA.
> Clarify lowercasing of DataStoreFactory#findProperty
> ----------------------------------------------------
>
> Key: GORA-354
> URL: https://issues.apache.org/jira/browse/GORA-354
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-core
> Affects Versions: 0.5
> Reporter: Lewis John McGibbney
> Assignee: Tyler Palsulich
> Priority: Critical
> Fix For: 0.5
>
> Attachments: GORA-354.palsulich.070914.patch,
> GORA-354.palsulich.071414.full.patch, GORA-354.palsulich.071514.full.patch,
> GORA-354.unit-test.patch
>
>
> Right now it appears that the reading of key's and value's from
> DataStoreFactory#findProperty is a process which does not lowercase keys or
> values.
> This can result in undesired behavhiour meaning that configuration properties
> are not used properly @Runtime.
> The fix should be a lowercasing of all properties so that they can be stored
> within and read from the call to System properties.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
