Hi, John. Thank you! Things I have seen:
- The version of a maven dependency [1] should go on the Dependency Management of the root pom [2]. Same for [3] and from there, should not set the version there. - Set test dependencies' scope to test, at [4] and from there. - Set the indentation to 2 spaces for the pom [5] - Missing "t" in "localhost" at [6]. - Port 13 for Kudu? That is "Daytime Protocol" RFC 867 and you will need root permission to run it. The default port for kudu is 7051, isn't it? - I would ask you to add the same functionality to load the mapping from configuration as in HBase's store [7] in you KuduStore [8]. This will have implications on your readMapping at [9], so take a look at the one for HBase at [10] - I know it is in other backends, but avoid RuntimeExceptions (at least in Java since we have the checked ones) like in [11]. You can wrap them in GoraException. An example is [12] And nothing more :) Keep going, good job. [1] - https://github.com/jhnmora000/gora/blob/GORA-485/gora-kudu/pom.xml#L98 [2] - https://github.com/jhnmora000/gora/blob/GORA-485/pom.xml#L890 [3] - https://github.com/jhnmora000/gora/blob/GORA-485/gora-kudu/pom.xml#L121 [4] - https://github.com/jhnmora000/gora/blob/GORA-485/gora-kudu/pom.xml#L180 [5] - https://github.com/jhnmora000/gora/blob/GORA-485/gora-kudu/pom.xml [6] - https://github.com/jhnmora000/gora/blob/GORA-485/gora-kudu/src/test/resources/gora.properties#L18 [7] - https://github.com/jhnmora000/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L92 [8] - https://github.com/jhnmora000/gora/blob/GORA-485/gora-kudu/src/main/java/org/apache/gora/kudu/store/KuduStore.java#L53 [9] - https://github.com/jhnmora000/gora/blob/GORA-485/gora-kudu/src/main/java/org/apache/gora/kudu/mapping/KuduMappingBuilder.java#L81 [10] - https://github.com/jhnmora000/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L822 [11] - https://github.com/jhnmora000/gora/blob/GORA-485/gora-kudu/src/main/java/org/apache/gora/kudu/mapping/KuduMappingBuilder.java#L141 [12] - https://github.com/jhnmora000/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L268 Regards, Alfonso Nishikawa El sáb., 8 jun. 2019 a las 20:26, John Mora (<jhnmora...@gmail.com>) escribió: > Hi all. > > I have just updated my weekly reports on Cwiki [1]. This next week I think > I should be focusing on the create schema operation and solving the issue > of the partitioning configurations in the mapping file. > > Please let me know if you have suggestions, my last commits are available > here [2] > > [1] > https://cwiki.apache.org/confluence/display/GORA/GORA-485+Apache+Kudu+datastore+for+Gora+Reports > [2] https://github.com/jhnmora000/gora/tree/GORA-485 > > Best, > John > >
