On 21/05/2013, at 2:58 AM, Kyle Mahan <kyle.ma...@gmail.com> wrote: > I'm having a little trouble figuring out how (and at what granularity) to > test this feature. Here is my first attempt at testing "Duplicate files are > included in a ZIP and TAR by default." for example: > https://gist.github.com/kylewm/5613537. It confirms that all three files are > visited by default for all copy operations, but I couldn't figure out how to > test ZIP and TAR specifically without creating a Project and Tasks, which > seems like I'd pulling in a lot more infrastructure than the other unit tests > do(?)
The unit test you have looks good. For the other coverage, you might add something to the integration tests in `ArchiveIntegrationTest` or perhaps add new `ZipIntegrationTest` and `TarIntegrationTest` test classes similar to `JarIntegrationTest`. > Feel free to be as critical as necessary... this is my first time working > with spock / any mocking library. > > Thanks, > Kyle > > > On Mon, May 13, 2013 at 5:36 PM, Adam Murdoch <adam.murd...@gradleware.com> > wrote: > > On 14/05/2013, at 12:26 AM, Kyle Mahan <kyle.ma...@gmail.com> wrote: > >> On Sun, May 12, 2013 at 4:37 PM, Adam Murdoch <adam.murd...@gradleware.com> >> wrote: >> >> Let us know if you're still interested in working on this and we can update >> the spec to add in some more details. I would love to see this implemented, >> and I know there are many, many people who would really appreciate having >> this feature. >> >> >> I am still interested, absolutely. By and large I understand the DSL >> additions you suggested, I suspect I'll have a couple of questions (mainly >> I'm not sure when to use field='value' vs. field 'value' in gradle in >> general) but those can wait until the spec is ready. Thanks! >> > > > I've updated the spec to add some stories: > https://github.com/gradle/gradle/blob/master/design-docs/duplicate-entries-in-archives.md > > The first 4 stories in the spec deal with the stuff we've discussed here. > Feel free to implement any or all (or none) of these stories. Let us know if > you have any questions or if you want someone to look over your changes > before you do a pull request. > > I also added a whole heap of placeholder stories for other improvements we > could make to the copy/archive tasks, as inspiration for others and as a > reminder for us. If you're interested, we'd welcome pull requests for any of > these stories too. > > > -- > Adam Murdoch > Gradle Co-founder > http://www.gradle.org > VP of Engineering, Gradleware Inc. - Gradle Training, Support, Consulting > http://www.gradleware.com > > Join us at the Gradle Summit 2013, June 13th and 14th in Santa Clara, CA: > http://www.gradlesummit.com > > -- Adam Murdoch Gradle Co-founder http://www.gradle.org VP of Engineering, Gradleware Inc. - Gradle Training, Support, Consulting http://www.gradleware.com Join us at the Gradle Summit 2013, June 13th and 14th in Santa Clara, CA: http://www.gradlesummit.com
