[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.

[chemikadze]

Github user chemikadze commented on a diff in the pull request:

    https://github.com/apache/incubator-griffin/pull/444#discussion_r230578522
  
    --- Diff: 
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java ---
    @@ -158,17 +162,22 @@ public JobServiceImpl() {
             } catch (SchedulerException e) {
                 LOGGER.error("Failed to get RUNNING jobs.", e);
                 throw new GriffinException
    -                    .ServiceException("Failed to get RUNNING jobs.", e);
    +                .ServiceException("Failed to get RUNNING jobs.", e);
             }
             return dataList;
         }
     
         @Override
         public AbstractJob addJob(AbstractJob job) throws Exception {
    +        JobEvent jobEvent = JobEvent.yieldJobEventBeforeCreation(null);
    --- End diff --
    
    shouldn't job be passed here? this would allow to validate some job 
parameters, for example


---