Github user gavlyukovskiy commented on a diff in the pull request:

    https://github.com/apache/incubator-griffin/pull/444#discussion_r231008571
  
    --- Diff: 
service/src/main/java/org/apache/griffin/core/event/GriffinEventListeners.java 
---
    @@ -0,0 +1,51 @@
    +package org.apache.griffin.core.event;
    +
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +import org.springframework.beans.BeansException;
    +import org.springframework.beans.factory.annotation.Autowired;
    +import org.springframework.beans.factory.annotation.Value;
    +import org.springframework.boot.context.properties.ConfigurationProperties;
    +import org.springframework.context.ApplicationContext;
    +import org.springframework.context.annotation.Bean;
    +import org.springframework.context.annotation.Configuration;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +@Configuration
    +@ConfigurationProperties(prefix = "internal.event")
    --- End diff --
    
    I'm not sure you need it here, this will map all class fields (that have 
setters and getters) to properties.


---

Reply via email to