Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/444#discussion_r231173157 --- Diff: service/src/main/java/org/apache/griffin/core/event/GriffinEventListeners.java --- @@ -0,0 +1,51 @@ +package org.apache.griffin.core.event; + +import java.util.ArrayList; +import java.util.List; + +import org.springframework.beans.BeansException; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.beans.factory.annotation.Value; +import org.springframework.boot.context.properties.ConfigurationProperties; +import org.springframework.context.ApplicationContext; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +@Configuration +@ConfigurationProperties(prefix = "internal.event") --- End diff -- right. @toyboxman ConfigurationProperties mainly for configuration bean, I see you have used Value, which make sense since you have only one value properties here. So I agree with @gavlyukovskiy, I don't think we need support configuration bean here.
---