You initial dialog is a good start, but what should it hold: all the pref keys from Console? Or just start with maxOutputChars?
The log file UI should be added once #8180 is done. I never touched GroovyConsole before, but it seems interesting. Reminds me of ANTLRWorks which I just used the other week for some small parser. Also, this console would also make a fine IDE plugin. Any particular reason GroovyConsole has to be standalone? --emi On Fri, May 19, 2017 at 6:01 PM, John Wagenleitner < john.wagenleit...@gmail.com> wrote: > Hi Emilian, > > I added a comment on that issue, I think it would also be handy to have a > new Preferences dialog for general settings such as this. Having a dialog > behind a new menu item such as Edit > Preferences could have an edit box > for inputting/displaying the output limit that is backed by a preference. > This could also be where the log to file option could be place (another > request [1]). In case some bits may be helpful, I started to play with > this a while back just to get more familiar with Swing/Groovy but never > finished [2]. > > Glad to hear you found this issue on the help wanted site. > > John > > [1] https://issues.apache.org/jira/browse/GROOVY-8180 > [2] https://github.com/jwagenleitner/groovy/commit/ > f0181f1564fdb0357b3852d15b0730582cc468ce > > On Fri, May 19, 2017 at 7:31 AM, Emilian Bold <emilian.b...@gmail.com> > wrote: > >> Hello, >> >> I would like to help out with the task listed at >> https://helpwanted.apache.org/task.html?72ff9c55 >> >> Console.groovy maxOutputChars already has a System.property so I'm not >> certain what's required for #GROOVY-3270, perhaps something like: >> >> - int maxOutputChars = >> System.getProperty('groovy.console.output.limit','20000') >> as int >> + int maxOutputChars = prefs.getInt("outputLimit", 20000) >> >> --emi >> > >
